freebsd: Increase consistancy with libc implementation#36
Merged
newpavlov merged 1 commit intorust-random:masterfrom Jun 19, 2019
Merged
freebsd: Increase consistancy with libc implementation#36newpavlov merged 1 commit intorust-random:masterfrom
newpavlov merged 1 commit intorust-random:masterfrom
Conversation
Closed
Member
|
And yet that implementation still has a limit of 256 bytes, so unless someone wants to check up on the kernel source code we should keep the chunking I think. |
Member
|
IIUC if we provide buffer larger than 256 bytes, kernel will fill only first 256 bytes and will return 256. Thus we don't need explicit chunking. |
Member
Author
This is correct, I also think the the 256 bytes is an implementation detail; I couldn't find documentation for the behavior. In that case, this implementation no longer makes assumptions about how KERN ARND works. |
Member
|
In that case, 👍 . Over to you @newpavlov |
takumi-earth
pushed a commit
to earthlings-dev/getrandom
that referenced
this pull request
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #35 @myfreeweb pointed out that the FreeBSD's libc implemenation calls
kern_arndin a loop, and simply retries if the syscall returns a short buffer.There doesn't seem like a good reason to differ from their implementation, so this PR changes the implementation to be more like the one for Linux
getrandom.